That is infact how it works.
if Agony said "Gains Melee -2" then the creature would only suffer the penalty on his first attack as per the criteria of the Melee +/- rule definition.
But, Agony reads "whenever it makes a non spell attack" and so is open to every attack made.
Agony can also be read as "Hyrda Muzzle"